Change test:all to clean up each example after running it #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #91
I ran out of space on disk when first running the exhaustive tests. 😅 I think it uses > 10GB of space for all the dependencies of all the examples.
This PR improves the exhaustive tests to clean up each example after running it. My editor also cleaned up some whitespace (I recommend hiding whitespaces changes on the diff).
Regarding the old
removeTemporaryTestFilesapproach of removing the entire temp folder at the beginning of the exhaustive test suite, I was worried about removing it since it might cause issues for users who have run the exhaustive test suite already and will have the example folders already there. But on second thought and after some sanity checks, it shouldn't be an issue since the worst thing that could happen is thatyarn installis run and the dependencies are already there.Also, while working on this, I noticed some examples are not passing. I will try to fix them in a separate PR.