Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added react-copy-write example for react #59

Merged
merged 3 commits into from
May 25, 2018
Merged

Added react-copy-write example for react #59

merged 3 commits into from
May 25, 2018

Conversation

juandc
Copy link
Contributor

@juandc juandc commented May 21, 2018

Solves #58 for react.

@GantMan GantMan added the evaluating Looking through the PR or Researching the request label May 23, 2018
GantMan
GantMan reviewed May 25, 2018
View reviewed changes
Copy link
Owner

@GantMan GantMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about separating the state management down to the components?

We kind of do this on examples that allow the change in one component to roll through to another without an obvious parent. Take a look at some of the others and let me know.

Thoughts?

juandc
juandc commented May 25, 2018
View reviewed changes
Copy link
Contributor Author

@juandc juandc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

GantMan
GantMan approved these changes May 25, 2018
View reviewed changes
Copy link
Owner

@GantMan GantMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@GantMan GantMan merged commit 6739bc5 into GantMan:master May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GantMan GantMan GantMan approved these changes

Assignees
No one assigned
Labels
evaluating Looking through the PR or Researching the request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juandc @GantMan