Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Fields to HubSpot Upload #376

Merged
merged 1 commit into from
May 23, 2024
Merged

Add New Fields to HubSpot Upload #376

merged 1 commit into from
May 23, 2024

Conversation

CalebPena
Copy link
Collaborator

What (if any) features are you implementing?

  • Send county field to HubSpot.
  • Send household size field to HubSpot.
  • Send age fields to HubSpot for every household member.

What (if anything) did you refactor?

  • Capture HubSpot errors in Sentry.

@CalebPena CalebPena added the impact-high Significant possible impact on data, security or user experience. Req lead dev + 1 review. label May 22, 2024
Copy link
Collaborator

@myang1010 myang1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.
One question, are we gradually moving away from single quotes?

@CalebPena
Copy link
Collaborator Author

Code looks good. One question, are we gradually moving away from single quotes?

Yes, I have a pr to add the black formatter, I am just waiting for a good time to avoid merge conflict. Will merge that pr after the admin redesign pr is merged.

@CalebPena CalebPena merged commit d48219e into dev May 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact-high Significant possible impact on data, security or user experience. Req lead dev + 1 review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants