Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10 create the friends list component #57

Merged
merged 12 commits into from
May 22, 2024

Conversation

zmattes04
Copy link
Collaborator

Developer: Zach Mattes

Closes #10

Pull Request Summary

Created a fully functional friends list that uses the user that is signed in.
Functioanality:
Add friend by _id
Once added a friend can quickly be added to any of the logged in users groups through a dropdown menu
There is also a delete button that removes the friend from the logged in users friends list

Every thing works through the backend and is updated in the frontend accordingly.

Modifications

I modified mostly just my new file "Friends_List_Component"
Added a new request for users that was to remove a friend for a certain users friends list (backend)
(In my demo below I added a spot on the navbar to go to my friends but i didn't push that because we are putting this in profile) so technically no way to currently to test it anymore but lmk if you guys want me to push that code, i still have it.

Testing Considerations

Tested with the frontend view/ console log/ and also verified by using boomerang for backend.

Pull Request Checklist

  • Code is neat, readable, and works
  • Comments are appropriate
  • The commit messages follows our guidelines
  • The developer name is specified
  • The summary is completed
  • Assign reviewers

Screenshots/Screencast

Look in groupchat.

{put screenshots of your change, or even better a screencast displaying the functionality}

@zmattes04 zmattes04 linked an issue May 22, 2024 that may be closed by this pull request
@zmattes04 zmattes04 requested review from SilveerDusk and jhagendoornCP and removed request for SilveerDusk and jhagendoornCP May 22, 2024 21:08
@zmattes04 zmattes04 requested review from jhagendoornCP and removed request for SilveerDusk May 22, 2024 21:12
@SilveerDusk
Copy link
Collaborator

@ZachAttackUS Check the CI testing details to see why the build failed. I think it involves there being no user._id attribute when the user isnt signed in

@SilveerDusk
Copy link
Collaborator

Other wise looking good and getting very close, feel free to merge once CI Testing passes all tests!

@SilveerDusk
Copy link
Collaborator

yayyyy

@SilveerDusk SilveerDusk requested review from SilveerDusk and removed request for jhagendoornCP May 22, 2024 22:34
@zmattes04 zmattes04 merged commit fddf964 into main May 22, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create the Friends List Component
2 participants