-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
10 create the friends list component #57
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmattes04
requested review from
SilveerDusk and
jhagendoornCP
and removed request for
SilveerDusk and
jhagendoornCP
May 22, 2024 21:08
zmattes04
requested review from
jhagendoornCP
and removed request for
SilveerDusk
May 22, 2024 21:12
@ZachAttackUS Check the CI testing details to see why the build failed. I think it involves there being no user._id attribute when the user isnt signed in |
Other wise looking good and getting very close, feel free to merge once CI Testing passes all tests! |
yayyyy |
SilveerDusk
requested review from
SilveerDusk
and removed request for
jhagendoornCP
May 22, 2024 22:34
SilveerDusk
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer: Zach Mattes
Closes #10
Pull Request Summary
Created a fully functional friends list that uses the user that is signed in.
Functioanality:
Add friend by _id
Once added a friend can quickly be added to any of the logged in users groups through a dropdown menu
There is also a delete button that removes the friend from the logged in users friends list
Every thing works through the backend and is updated in the frontend accordingly.
Modifications
I modified mostly just my new file "Friends_List_Component"
Added a new request for users that was to remove a friend for a certain users friends list (backend)
(In my demo below I added a spot on the navbar to go to my friends but i didn't push that because we are putting this in profile) so technically no way to currently to test it anymore but lmk if you guys want me to push that code, i still have it.
Testing Considerations
Tested with the frontend view/ console log/ and also verified by using boomerang for backend.
Pull Request Checklist
Screenshots/Screencast
Look in groupchat.
{put screenshots of your change, or even better a screencast displaying the functionality}