Remove redundant useeffect

GatherPress · Nov 2, 2024 · ac7ef12 · ac7ef12
1 parent e378324
commit ac7ef12
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 12 deletions.
diff --git a/build/blocks/venue/index.asset.php b/build/blocks/venue/index.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('moment', 'react', 'react-jsx-runtime', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-compose', 'wp-data', 'wp-date', 'wp-element', 'wp-i18n'), 'version' => '9d47607a59ae02933048');
+<?php return array('dependencies' => array('moment', 'react', 'react-jsx-runtime', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-compose', 'wp-data', 'wp-date', 'wp-element', 'wp-i18n'), 'version' => '2f49f9baf258110fbb88');
diff --git a/build/blocks/venue/index.js b/build/blocks/venue/index.js
diff --git a/build/panels.asset.php b/build/panels.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('moment', 'react-jsx-runtime', 'wp-components', 'wp-compose', 'wp-data', 'wp-date', 'wp-dom-ready', 'wp-editor', 'wp-element', 'wp-i18n', 'wp-plugins'), 'version' => '57ffe70d2fa312b2a0da');
+<?php return array('dependencies' => array('moment', 'react-jsx-runtime', 'wp-components', 'wp-compose', 'wp-data', 'wp-date', 'wp-dom-ready', 'wp-editor', 'wp-element', 'wp-i18n', 'wp-plugins'), 'version' => 'f805b57db54750eb05ac');
diff --git a/build/panels.js b/build/panels.js
diff --git a/src/components/VenueInformation.js b/src/components/VenueInformation.js
@@ -47,9 +47,6 @@ const VenueInformation = () => {
 		[]
 	);
 
-	useEffect(() => {
-	}, [mapCustomLatLong]);
-
 	let venueInformationMetaData = useSelect(
 		(select) =>
 			select('core/editor').getEditedPostAttribute('meta')
@@ -75,6 +72,7 @@ const VenueInformation = () => {
 	Listener({ setFullAddress, setPhoneNumber, setWebsite });
 
 	const updateVenueMetaRef = useRef(updateVenueMeta);
+
 	const getData = useCallback(() => {
 		let lat = null;
 		let lng = null;
@@ -108,11 +106,23 @@ const VenueInformation = () => {
 					});
 				}
 			});
-	}, [fullAddress, mapCustomLatLong, updateVenueMetaRef]);
+	}, [
+		fullAddress,
+		mapCustomLatLong,
+		updateVenueLatitude,
+		updateVenueLongitude,
+	]);
+
+	const debouncedGetData = useDebounce(getData, 300);
 
 	useEffect(() => {
-		getData();
-	}, [getData]);
+		updateVenueMetaRef.current = updateVenueMeta;
+	}, [updateVenueMeta]);
+
+	useEffect(() => {
+		debouncedGetData();
+	}, [fullAddress, debouncedGetData]);
+
 	return (
 		<>
 			<TextControl