-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for new block variations 2/3: Make event query respect ORDERBY, ORDER and 'unfinished events' #889
Merged
mauteri
merged 12 commits into
GatherPress:develop
from
carstingaxion:feature/query-order-by
Oct 12, 2024
Merged
Prepare for new block variations 2/3: Make event query respect ORDERBY, ORDER and 'unfinished events' #889
mauteri
merged 12 commits into
GatherPress:develop
from
carstingaxion:feature/query-order-by
Oct 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carstingaxion
changed the title
Prepare for new block variations 2/x: Make event query respect ORDERBY, ORDER and 'inclusive running events'
Prepare for new block variations 2/x: Make event query respect ORDERBY, ORDER and 'unfinished events'
Sep 19, 2024
carstingaxion
changed the title
Prepare for new block variations 2/x: Make event query respect ORDERBY, ORDER and 'unfinished events'
Prepare for new block variations 2/3: Make event query respect ORDERBY, ORDER and 'unfinished events'
Oct 5, 2024
Preview changes with PlaygroundYou can preview the recent changes for PR#889 with the following PHP versions: PHP Version 8.3
PHP Version 7.4
Download Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions. |
mauteri
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation to bring some block variations from the gatherpress-block-playground into the plugin as part of #626.
Description of the Change
To be able to use the full potential of the new (but not yet included) Event Query block, this PR introduces ordering capacities to the event-query methods. On top of that it add a boolean control, to allow to include started, but unfinished, events in the actual query.
The event queries can now be ordered by:
Closes #How to test the Change
Changelog Entry
Credits
Props @carstingaxion
Checklist: