New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set html language attributes correctly for emails #919

Merged

mauteri merged 1 commit into GatherPress:main from carstingaxion:fix/fragment-of-752-set-html-lang-attr

Sep 26, 2024

Collaborator

carstingaxion commented Sep 26, 2024 •

edited

Loading

Fragmentation of #752

Description of the Change

Until this PR GatherPress sends email with a fixed language attribute of "en-us", which doesn't reflect the sites or users locale.

~~Closes #~~

How to test the Change

Change your sites default language to anything else, than en_US.
Send yourself an email via an event
Check the html of the sent email for the lang-attribute on the html element.
This should reflect your set language

Changelog Entry

Fixed - Set html language attributes correctly for emails

Credits

Props @carstingaxion

Checklist:

I agree to follow this project's Code of Conduct.
I have updated the documentation accordingly.
I have added tests to cover my change.
All new and existing tests pass.


          Set html language attributes correctly for the email

github-actions bot commented Sep 26, 2024

Preview changes with Playground

You can preview the recent changes for PR#919 with the following PHP versions:

PHP Version 8.3

PHP Version 7.4

Download .zip with build changes

Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions.

mauteri approved these changes

View reviewed changes

mauteri merged commit 3a1ee6b into GatherPress:main

13 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet