Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEW action PHPStan & 36 little 🐛 fixes #931

Merged
merged 40 commits into from
Oct 4, 2024
Merged

NEW action PHPStan & 36 little 🐛 fixes #931

merged 40 commits into from
Oct 4, 2024

Commits on Oct 1, 2024

  1. NEW static analyze test PHPStan (for WordPress)

    @carstingaxion
    carstingaxion committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    c2a12ea View commit details
    Browse the repository at this point in the history

  2. NEW Github actions workflowe to run PHPStan

    @carstingaxion
    carstingaxion committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    c9517df View commit details
    Browse the repository at this point in the history

  3. Minor fix to prevent phpdoc.parseError

    @carstingaxion
    carstingaxion committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    05d247c View commit details
    Browse the repository at this point in the history

  4. Use additional bleedingEdge config

    @carstingaxion
    carstingaxion committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    63b20e6 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Fix: Parameter #1 $version1 of function version_compare expects strin… 

    …g, int<50207, max> given.
    @carstingaxion
    carstingaxion committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    6dab970 View commit details
    Browse the repository at this point in the history

  2. Fix: Parameter #1 $term_id of function wp_update_term expects int, st… 

    …ring given.
    @carstingaxion
    carstingaxion committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    7bdf65a View commit details
    Browse the repository at this point in the history

  3. Fix: Path in require_once() "./wp-admin/includes/upgrade.php" is not … 

    …a file or it does not exist.
    @carstingaxion
    carstingaxion committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    90b8a0b View commit details
    Browse the repository at this point in the history

  4. Fix: Call to sprintf contains 1 placeholder, 2 values given.

    @carstingaxion
    carstingaxion committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    ffeecba View commit details
    Browse the repository at this point in the history

  5. Fix: Parameter #1 $new_blog_id of function switch_to_blog expects int… 

    …, string given.
    @carstingaxion
    carstingaxion committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    dd691e4 View commit details
    Browse the repository at this point in the history

  6. Fix: Parameter #1 $term_id of function wp_update_term expects int, st… 

    …ring given.
    @carstingaxion
    carstingaxion committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    3a57156 View commit details
    Browse the repository at this point in the history

  7. Fix: Variable $suffix might not be defined.

    @carstingaxion
    carstingaxion committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    e4ea845 View commit details
    Browse the repository at this point in the history

  8. Fix & Unit test: Method GatherPress\Core\Settings::sort_sub_pages_by_… 

    …priority() should return int but returns bool.
    @carstingaxion
    carstingaxion committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    684d1ec View commit details
    Browse the repository at this point in the history

  9. Fix: Parameter #3 $group of function wp_cache_set expects string, int… 

    … given.
    @carstingaxion
    carstingaxion committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    968ac3b View commit details
    Browse the repository at this point in the history

  10. Parameter #2 $callback of function usort expects callable(array, arra… 

    …y): int, array{$this(GatherPress\Core\Rsvp), 'sort_by_timestamp'} given.
    @carstingaxion
    carstingaxion committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    3242163 View commit details
    Browse the repository at this point in the history

  11. Revert "Fix: Parameter #3 $group of function wp_cache_set expects str… 

    …ing, int given."

This reverts commit 968ac3b.
    @carstingaxion
    carstingaxion committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    2ed2443 View commit details
    Browse the repository at this point in the history

  12. Fix: One or more @ param tags has an invalid name or invalid syntax.

    @carstingaxion
    carstingaxion committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    c86472d View commit details
    Browse the repository at this point in the history

  13. Fix: Callback expects 1 parameter, $accepted_args is set to 2.

    @carstingaxion
    carstingaxion committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    0d4b8fd View commit details
    Browse the repository at this point in the history

  14. Fix: Expression on left side of ?? is not nullable. (Because get_perm… 

    …alink returns FALSE, not NULL if it fails)
    @carstingaxion
    carstingaxion committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    b237d92 View commit details
    Browse the repository at this point in the history

  15. Fix: Parameter #1 $string of function str_pad expects string, int given.

    @carstingaxion
    carstingaxion committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    f0e15db View commit details
    Browse the repository at this point in the history

  16. Fix: Class WP_Comment referenced with incorrect case: WP_comment.

    @carstingaxion
    carstingaxion committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    b754286 View commit details
    Browse the repository at this point in the history

  17. Fix: Filter callback return statement is missing. 

    Because 'pre_get_comments' is an action, not a filter.
    @carstingaxion
    carstingaxion committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    4125173 View commit details
    Browse the repository at this point in the history

  18. Ignore CS warning: Universal.Operators.DisallowShortTernary.Found

    @carstingaxion
    carstingaxion committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    511330d View commit details
    Browse the repository at this point in the history

  19. Fix: Instanceof between WP_Comment_Query and WP_Comment_Query will al… 

    …ways evaluate to true.
    @carstingaxion
    carstingaxion committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    33fcfeb View commit details
    Browse the repository at this point in the history

  20. Fix: Access to an undefined property WP_Comment_Query::$tax_query.

    @carstingaxion
    carstingaxion committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    df75ff9 View commit details
    Browse the repository at this point in the history

  21. Fix: Function wxr_cdata not found. 

    (szepeviktor/phpstan-wordpress#241)
    @carstingaxion
    carstingaxion committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    8b82f0f View commit details
    Browse the repository at this point in the history

  22. Add shortcut to run phpstan 

    Which is way more performant:

vendor/bin/phpstan analyze -vv --memory-limit=2G
  Elapsed time: 5 seconds
  Used memory: 663.28 MB

  Elapsed time: 10 seconds
  Used memory: 1.08 GB

composer test:phpstan
(which runs `vendor/bin/phpstan analyze -vv --memory-limit=2G` under the hood)
  Elapsed time:
  Used memory: 70.5 MB
    @carstingaxion
    carstingaxion committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    575719b View commit details
    Browse the repository at this point in the history

  23. Fix: Variable $option might not be defined.

    @carstingaxion
    carstingaxion committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    ca595d5 View commit details
    Browse the repository at this point in the history

  24. Fix: Result of function selected (void) is used. AND (Parameter #1 (v… 

    …oid) of echo cannot be converted to string.) which was a false positive.
    @carstingaxion
    carstingaxion committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    6f36dc1 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Fix: Expression on left side of ?? is not nullable.

    @carstingaxion
    carstingaxion committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    5685aad View commit details
    Browse the repository at this point in the history

  2. Fix: Expression "$blocks" on a separate line does not do anything.

    @carstingaxion
    carstingaxion committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    4b7c27f View commit details
    Browse the repository at this point in the history

  3. Fix: Parameter #1 $comment_id of function get_comment_meta expects in… 

    …t, string given. AND Parameter #1 $object_ids of function wp_get_object_terms expects array<int>|int, string given.
    @carstingaxion
    carstingaxion committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    e58785e View commit details
    Browse the repository at this point in the history

  4. Fix: Call to function is_wp_error() with int|string|false will always… 

    … evaluate to false.
    @carstingaxion
    carstingaxion committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    0ad3a3e View commit details
    Browse the repository at this point in the history

  5. Fix: Offset 'approved' on array{approved: int, awaiting_moderation: i… 

    …nt, spam: int, trash: int, post-trashed: int, total_comments: int, all: int} on left side of ?? always exists and is not nullable.
    @carstingaxion
    carstingaxion committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    9d967fb View commit details
    Browse the repository at this point in the history

  6. Fix: Property WP_Query::$queried_object_id (int) does not accept string.

    @carstingaxion
    carstingaxion committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    64f0271 View commit details
    Browse the repository at this point in the history

  7. Fix: Property WP_Query::$is_post_type_archive (bool) does not accept … 

    …array<int, string>.
    @carstingaxion
    carstingaxion committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    2c3585c View commit details
    Browse the repository at this point in the history

  8. Fix wp_cache_set argument.

    @mauteri
    mauteri committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    ea4466e View commit details
    Browse the repository at this point in the history

  9. Fix return on method, fix cache bug, update unit tests.

    @mauteri
    mauteri committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    30599f2 View commit details
    Browse the repository at this point in the history

  10. Small fixes.

    @mauteri
    mauteri committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    b47a6ca View commit details
    Browse the repository at this point in the history

  11. Name change.

    @mauteri
    mauteri committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    aa69812 View commit details
    Browse the repository at this point in the history

  12. Add ignore.

    @mauteri
    mauteri committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    c615cd5 View commit details
    Browse the repository at this point in the history