Set & use missing cache group

[carstingaxion]

One of the errors, that came up in #931 was :

Parameter # 3 $group of function wp_cache_set expects string, int given.

in /includes/core/classes/class-rsvp.php

Until now, wp_cache_set was called with its expiration time as third parameter, which is supposed to be the cache-group.

(see https://developer.wordpress.org/reference/functions/wp_cache_set/)

Description of the Change

I thought, that it might be the easiest solution, to just use the 'default' cache-group, which was probably meant to be done here.

⚠️ Unfortunately this led to a unit test error, that I wasn't able to solve (now).

1) GatherPress\Tests\Core\Test_Rsvp::test_responses
Failed not_attending responses are empty after $user_id_2 was deleted.
Failed asserting that an array is empty.

Closes #

How to test the Change

Changelog Entry

Added - New feature
Changed - Existing functionality
Deprecated - Soon-to-be removed feature
Removed - Feature
Fixed - Bug fix
Security - Vulnerability

Credits

Props @carstingaxion

Checklist:

• I agree to follow this project's Code of Conduct.
• I have updated the documentation accordingly.
• I have added tests to cover my change.
• All new and existing tests pass.

[github-actions]

Preview changes with Playground

You can preview the recent changes for PR#933 with the following PHP versions:

PHP Version 8.3

• Normal WordPress playground for PR#933
• Seamless WordPress playground for PR#933
• WordPress playground Builder for PR#933

PHP Version 7.4

• Normal WordPress playground for PR#933
• Seamless WordPress playground for PR#933
• WordPress playground Builder for PR#933

Download .zip with build changes

Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions.

[mauteri]

@carstingaxion we can close this, fixed it here #931