[HIP] Implement coarse-grained memory advice for the HIP adapter #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeWeb
force-pushed
the
georgi/hip_memadvise_coarse_grained
branch
from
71cf456
to
0dbcf8c
Compare
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
Co-authored-by: Jakub Chlanda <[email protected]>
Co-authored-by: Jakub Chlanda <[email protected]>
kbenzie
force-pushed
the
georgi/hip_memadvise
branch
from
5a4806f
to
c10968f
Compare
Adds an extra event in the first command list associated to the CommandBuffer execution to obtain the start time of the graph execution.
Get the command-buffer start and end timestamps from this memory. Move events reset from the middle command list to the first to allow the copy of the profiling info in the last command list and relax command list order.
GeorgeWeb
force-pushed
the
georgi/hip_memadvise_coarse_grained
branch
2 times, most recently
from
7731392
to
617f975
Compare
GeorgeWeb
force-pushed
the
georgi/hip_memadvise_coarse_grained
branch
from
617f975
to
7c1756a
Compare
GeorgeWeb
changed the title
When tests are aborted or failed at the assertion, the match script receives "Aborted" or "Segmentation fault" as an input and compares it with the match file. Previous match script allowed those tests to pass despite not matching this input.
GeorgeWeb
force-pushed
the
georgi/hip_memadvise_coarse_grained
branch
from
65b9fba
to
c53137f
Compare
…er-fix [UR] Add adapter leak-checking tests
[EXP][CMDBUF] Add support for recovering CommandBuffer profiling information
[HIP] Remove inline from helper
[HIP] Add support for global variable read write
GeorgeWeb
force-pushed
the
georgi/hip_memadvise_coarse_grained
branch
2 times, most recently
from
732dcaf
to
c817d04
Compare
GeorgeWeb
force-pushed
the
georgi/hip_memadvise_coarse_grained
branch
from
c817d04
to
52959b8
Compare
GeorgeWeb
force-pushed
the
georgi/hip_memadvise_coarse_grained
branch
from
52959b8
to
7fdaed2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements coarse grained memory access via a memory advice flag for HIP platforms on AMD hardware.
Related SYCL runtime changes and tests: GeorgeWeb/llvm#1