fix: rename override -> override_existing in UserBatch.cs #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"override" is the incorrect variable name when using UpsertUsersAsync api. Instead "override_existing" should be used
sinapy
changed the title
|
@JimmyPettersson85 , @itsmeadi , could you take a look? |
JimmyPettersson85
approved these changes
Dec 19, 2024
|
Thanks @JimmyPettersson85 . Can this PR be merged? |
yes, I was waiting for the tests to be run, not sure why nothing happens. Can you try to remove @itsmeadi as reviewer? |
|
I don't have the option to remove @itsmeadi from the reviewers. When I raised the PR, both code owners were assigned to review it automatically. |
|
merged, will create a new release |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"override" is the incorrect variable name when using UpsertUsersAsync api. Instead "override_existing" should be used