Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: typo in engines declaration #55

Merged
merged 1 commit into from
Sep 17, 2024
Merged

chore: typo in engines declaration #55

merged 1 commit into from
Sep 17, 2024

Conversation

oliverlaz
Copy link
Member

Overview

Fixes a typo in the engines declaration and switches to standardized spec:

Copy link
Collaborator

@szuperaz szuperaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

@szuperaz
Copy link
Collaborator

Test are failing because some endpoints were moved, internal discussion here: https://github.com/GetStream/stream-node/actions/runs/10899155233/job/30243951440?pr=55 - I'm investigating if we can throw a better error here, it should be a 404, but that's outside of this PR, so I'm going to merge it

@szuperaz szuperaz merged commit bcd3919 into main Sep 17, 2024
3 of 7 checks passed
@szuperaz szuperaz deleted the fix-engines branch September 17, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants