feat: prevent flickering when a new stream arrives for an existing pa…

…rticipant
GetStream · Oct 31, 2024 · 6c79775 · 6c79775
1 parent f5a4bb7
commit 6c79775
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/packages/client/src/rtc/Subscriber.ts b/packages/client/src/rtc/Subscriber.ts
@@ -218,7 +218,15 @@ export class Subscriber {
       this.logger('error', `Unknown track type: ${rawTrackType}`);
       return;
     }
+
     const previousStream = participantToUpdate[streamKindProp];
+
+    // replace the previous stream with the new one, prevents flickering
+    this.state.updateParticipant(participantToUpdate.sessionId, {
+      [streamKindProp]: primaryStream,
+    });
+
+    // now, dispose the previous stream
     if (previousStream) {
       this.logger(
         'info',
@@ -229,9 +237,6 @@ export class Subscriber {
         previousStream.removeTrack(t);
       });
     }
-    this.state.updateParticipant(participantToUpdate.sessionId, {
-      [streamKindProp]: primaryStream,
-    });
   };
 
   private onIceCandidate = (e: RTCPeerConnectionIceEvent) => {