Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow reusing call instance [WIP] #1039

Closed
wants to merge 16 commits into from

Conversation

oliverlaz
Copy link
Member

Overview

Allows a call instance to be reused for multiple .join() -> .leave() -> .join() cycles.

Based on #1011 - I'll update the base once #1011 is tested and merged.

Copy link
Contributor

@szuperaz szuperaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could add an unwatch method that unregisters coordinator WS event listeners. It could be useful if a customer doesn't care about a call instance anymore, and then unwatch should make it possible to GC the call instance.

@oliverlaz
Copy link
Member Author

Maybe we could add an unwatch method that unregisters coordinator WS event listeners. It could be useful if a customer doesn't care about a call instance anymore, and then unwatch should make it possible to GC the call instance.

I don't think our Coordinator API has such an API. We can handle this in the client, but the backend will still send events for unwatched calls.

@szuperaz
Copy link
Contributor

Maybe we could add an unwatch method that unregisters coordinator WS event listeners. It could be useful if a customer doesn't care about a call instance anymore, and then unwatch should make it possible to GC the call instance.

I don't think our Coordinator API has such an API. We can handle this in the client, but the backend will still send events for unwatched calls.

Yes, I meant handling client-side. I also didn't see backend support for this.

@oliverlaz
Copy link
Member Author

Implemented with: #1433

@oliverlaz oliverlaz closed this Aug 30, 2024
@oliverlaz oliverlaz deleted the allow-reusing-call-instance branch August 30, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants