feat: add audio output level controls #831
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n if audio is disabled
…gleAudioOutputButton in Lobby
…gleAudioOutputButton in MeetingUI
MartinCupela
requested review from
oliverlaz,
santhoshvai,
szuperaz,
khushal87 and
arnautov-anton
oliverlaz
reviewed
Jul 21, 2023
…is set Co-authored-by: Oliver Lazoroski <[email protected]>
szuperaz
approved these changes
Jul 21, 2023
There was a problem hiding this comment.
- We should add docs to the Call & Participant state and Camera & Microhponse guides + UI docs
…stead of participant
…aster level in active call
# Conflicts: # packages/react-sdk/src/core/components/CallLayout/PaginatedGridLayout.tsx
oliverlaz
reviewed
Jul 21, 2023
packages/react-sdk/src/components/CallControls/ToggleAudioOutputButton.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Oliver Lazoroski <[email protected]>
oliverlaz
reviewed
Jul 21, 2023
packages/react-native-sdk/docusaurus/docs/reactnative/03-core/03-call-and-participant-state.mdx
Outdated
Show resolved
Hide resolved
packages/react-native-sdk/docusaurus/docs/reactnative/03-core/03-call-and-participant-state.mdx
Outdated
Show resolved
Hide resolved
packages/react-sdk/docusaurus/docs/React/02-guides/03-call-and-participant-state.mdx
Outdated
Show resolved
Hide resolved
packages/react-sdk/docusaurus/docs/React/02-guides/03-call-and-participant-state.mdx
Outdated
Show resolved
Hide resolved
oliverlaz
reviewed
Jul 25, 2023
packages/react-sdk/src/components/CallControls/AudioOutputLevelSlider.tsx
Outdated
Show resolved
Hide resolved
…icipant audio slider, allow thumb overflow on track sides
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Start tracking the audio output level in a call.
Specification
Client
Callclass exposes method to change the audio output level for a specific participant or for all participants and the default.participant.audioOutputLevel ?? masterAudioOutputLevelBindings
useMasterAudioOutputLevelhas been added. The value emitted by this hook is a fallback, ifStreamVideoParticipant.audioOutputLevelis undefined.React SDK
Audiocomponent now accepts optionalvolumeprop that changes the volume of the underlyingaudioelementAudioOutputLevelSlidercomponent has been added to control the level of audio output + its styles in styling package. The slider is draggable.ToggleAudioOutputButtonhas been enabled to turn on and off the audio output for all the users / participantsParticipantsActionsContextMenuallows to change the audio output level for each participantuseDraggablehook to the SDK hooksReact Dogfood
ToggleAudioOutputButtonhas been added to the MeetingUIAudioOutputLevelSliderhas been added to menu forToggleAudioOutputButton