Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support goLive({ notify: true }) #848

Merged
merged 5 commits into from
Jul 26, 2023
Merged

feat: support goLive({ notify: true }) #848

merged 5 commits into from
Jul 26, 2023

Conversation

sachaarbonel
Copy link
Member

@sachaarbonel sachaarbonel changed the title Support goLive({ notify: true }); feat: Support goLive({ notify: true }); Jul 24, 2023
@sachaarbonel sachaarbonel changed the title feat: Support goLive({ notify: true }); feat: support goLive({ notify: true }) Jul 24, 2023
@szuperaz
Copy link
Contributor

@sachaarbonel I updated how we set query param:
call.goLive() -> notify query param not set
call.goLive(false) -> notify=false query param set
call.goLive(true) -> notify=true query param set

@sachaarbonel sachaarbonel marked this pull request as ready for review July 26, 2023 12:38
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.7% 95.7% Coverage
0.0% 0.0% Duplication

@sachaarbonel sachaarbonel merged commit ed67b28 into main Jul 26, 2023
21 checks passed
@sachaarbonel sachaarbonel deleted the sachaarbonel-patch-1 branch July 26, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szuperaz szuperaz szuperaz approved these changes

@oliverlaz oliverlaz oliverlaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sachaarbonel @szuperaz @oliverlaz