docs(react-native): Advanced: Chat Integration - Chat in Video #854
Conversation
packages/react-native-sdk/docusaurus/docs/reactnative/06-advanced/02-chat-with-video.mdx
Outdated
Show resolved
Hide resolved
packages/react-native-sdk/docusaurus/docs/reactnative/06-advanced/02-chat-with-video.mdx
Show resolved
Hide resolved
packages/react-native-sdk/docusaurus/docs/reactnative/06-advanced/02-chat-with-video.mdx
Outdated
Show resolved
Hide resolved
| }, [client, cid]); | ||
|
|
||
| useEffect(() => { | ||
| if (!client || !channelWatched) { |
There was a problem hiding this comment.
I dont see the use case of channelWatched prop actually..
if the channel is not watched, it wont be inside activeChannels and so handleevent will set a count of 0.
There was a problem hiding this comment.
It is just a security check to avoid bugs if the channel is not watched. Good to have it for now I think
There was a problem hiding this comment.
no please, lets make it simpler
There was a problem hiding this comment.
just a security check to avoid bugs if the channel is not watched.
we an add a note for that.. lets strive to make it simpler
packages/react-native-sdk/docusaurus/docs/reactnative/06-advanced/02-chat-with-video.mdx
Outdated
Show resolved
Hide resolved
| const newChannel = await client.channel(CHANNEL_TYPE, CHANNEL_ID); | ||
| setChannel(newChannel); |
There was a problem hiding this comment.
cant we just watch here instead of useChannelWatch
There was a problem hiding this comment.
and there is no need to create the channel ?
There was a problem hiding this comment.
client.channel creates a channel automatically if not created. We created the channel already in the ChatScreen
There was a problem hiding this comment.
There was a problem hiding this comment.
@khushal87 you have linked, but please read the link
we must call channel.create() or channel.watch()
There was a problem hiding this comment.
Resolved since we call channel.watch(), we discussed yesterday.
| import { VideoCallUI } from './components/VideoCallUI'; | ||
| import { ChatWrapper } from './src/components/ChatWrapper'; |
There was a problem hiding this comment.
| import { VideoCallUI } from './components/VideoCallUI'; | |
| import { ChatWrapper } from './src/components/ChatWrapper'; | |
| import { VideoCallUI } from 'src/components/VideoCallUI'; | |
| import { ChatWrapper } from 'src/components/ChatWrapper'; |
|
Kudos, SonarCloud Quality Gate passed!
|
santhoshvai
deleted the
khushal87/advanced/chat-integration/chat-in-video
branch
No description provided.