-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Server-side participant pinning #881
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverlaz
requested review from
tbarbugli,
santhoshvai,
szuperaz,
vanGalilea,
MartinCupela,
khushal87 and
arnautov-anton
July 31, 2023 17:07
khushal87
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving changes for RN and pin and un-pin changes.
Pin for all needs to be tested.
Thanks, @oliverlaz for adding the changes to RN SDK. 🚀
khushal87
reviewed
Aug 1, 2023
Co-authored-by: Khushal Agarwal <[email protected]>
szuperaz
reviewed
Aug 1, 2023
packages/react-native-sdk/docusaurus/docs/reactnative/03-core/03-call-and-participant-state.mdx
Outdated
Show resolved
Hide resolved
MartinCupela
reviewed
Aug 1, 2023
packages/react-sdk/src/components/CallParticipantsList/CallParticipantListingItem.tsx
Show resolved
Hide resolved
arnautov-anton
approved these changes
Aug 3, 2023
szuperaz
approved these changes
Aug 3, 2023
MartinCupela
approved these changes
Aug 4, 2023
khushal87
reviewed
Aug 7, 2023
packages/react-native-sdk/src/components/participants/internal/ParticipantActions.tsx
Outdated
Show resolved
Hide resolved
khushal87
reviewed
Aug 7, 2023
packages/react-native-sdk/src/components/participants/ParticipantView.tsx
Outdated
Show resolved
Hide resolved
oliverlaz
changed the title
feat: Server-side participant pinning
feat!: Server-side participant pinning
Aug 7, 2023
khushal87
approved these changes
Aug 7, 2023
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds support for Server-Side participant pinning.
Reference: https://github.com/GetStream/chat/pull/5239, GetStream/protocol#174
Specs: https://www.notion.so/stream-wiki/Video-Pinning-2b348a962da742389f734b7fd9b1cf46
Breaking changes
This PR brings a small breaking change in the participant pinning API. Previously, we used to have
call.setParticipantPinnedAt
API which is now replaced withcall.pin(sessionId)
andcall.unpin(sessionId)
APIs.Additionally, the
participant.pinnedAt
property has been replaced with a newpin
structure of this shape: