Fix aspect ratio in VideoTextureViewRenderer when frame dimensions change #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to call
requestLayout()when the frame dimensions change inVideoTextureViewRender. If we don't do this thensetLayoutAspectRatio(..)inonLayout()is not called and theEglRendererwill then not properly draw the content because the frame size and aspect ratio are out of sync (aspect ratio is not updated).We found this error thanks to the issue report in GetStream/stream-video-android#679 - changing the scaling type with
VideoTextureViewRenderer.setScalingType(..)would not have an effect.I tested this change with our Video SDK demo app.