New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix onFirstFrameRendered() not called in VideoTextureViewRenderer #55

Merged

skydoves merged 1 commit into main from fix_onFirstFrameRendered

Aug 29, 2023

Contributor

DanielNovak commented Aug 29, 2023

The RendererEvents.onFirstFrameRendered() is never called because isFirstFrameRendered is set to false by default and the condition is wrong.


          Fix onFirstFrameRendered() not called in VideoTextureViewRenderer

68df029

DanielNovak added the bug label

DanielNovak requested a review from skydoves as a code owner

August 29, 2023 18:56

skydoves approved these changes

View reviewed changes

Member

skydoves left a comment

Looks good to me!

skydoves merged commit 9d155e3 into main

1 check passed

skydoves deleted the fix_onFirstFrameRendered branch

August 29, 2023 22:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug