Add listAll to StorageReference and reference to FirebaseStorage #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
| 1. Open the project in IntelliJ IDEA. | ||
| 2. Install cocoapods via `sudo gem install -n /usr/local/bin cocoapods` | ||
| 3. Install the GitLive plugin into IntelliJ | ||
| 4. After a gradle sync then run `firebase-storage:publishToMavenLocal` |
There was a problem hiding this comment.
Should be the top level gradle task publishToMavenLocal
nbransby
reviewed
Jul 9, 2023
| @@ -38,6 +38,7 @@ actual class FirebaseStorage(val js: firebase.storage.Storage) { | |||
| js.useEmulator(host, port) | |||
| } | |||
|
|
|||
| actual val reference: StorageReference get() = TODO() | |||
There was a problem hiding this comment.
Now implemented
nbransby
reviewed
Jul 9, 2023
Comment on lines
95
to
97
| actual val prefixes: List<StorageReference> get() = android.prefixes.map { StorageReference(it) } | ||
| actual val items: List<StorageReference> get() = android.items.map { StorageReference(it) } | ||
| actual val pageToken: String? get() = android.pageToken |
There was a problem hiding this comment.
using getters here but standard initialization in ios/js - if these properties are immutable (im assuming they are) then by lazy { .. } would be best otherwise if they are mutable then should be getters.
(pageToken can be a getter as its not wrapped)
There was a problem hiding this comment.
Went with the same standard initialization as the other platforms. These properties are, in-fact, immutable.
nbransby
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is adding some api surface to firebase storage. Also a little change to the readme to give some clarity of how to work on this project.
I was able to build this locally and consume it in a separate KMM project to access firebase storage. So that's fantastic.