-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add listAll to StorageReference and reference to FirebaseStorage #397
Add listAll to StorageReference and reference to FirebaseStorage #397
Conversation
README.md
Outdated
1. Open the project in IntelliJ IDEA. | ||
2. Install cocoapods via `sudo gem install -n /usr/local/bin cocoapods` | ||
3. Install the GitLive plugin into IntelliJ | ||
4. After a gradle sync then run `firebase-storage:publishToMavenLocal` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be the top level gradle task publishToMavenLocal
@@ -38,6 +38,7 @@ actual class FirebaseStorage(val js: firebase.storage.Storage) { | |||
js.useEmulator(host, port) | |||
} | |||
|
|||
actual val reference: StorageReference get() = TODO() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to implemented
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now implemented
actual val prefixes: List<StorageReference> get() = android.prefixes.map { StorageReference(it) } | ||
actual val items: List<StorageReference> get() = android.items.map { StorageReference(it) } | ||
actual val pageToken: String? get() = android.pageToken |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using getters here but standard initialization in ios/js - if these properties are immutable (im assuming they are) then by lazy { .. } would be best otherwise if they are mutable then should be getters.
(pageToken can be a getter as its not wrapped)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went with the same standard initialization as the other platforms. These properties are, in-fact, immutable.
This is adding some api surface to firebase storage. Also a little change to the readme to give some clarity of how to work on this project.
I was able to build this locally and consume it in a separate KMM project to access firebase storage. So that's fantastic.