Fix passing GCMSenderId to FirebaseOptions on Android/iOS #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbransby
reviewed
Jan 13, 2024
| @@ -29,11 +29,11 @@ actual fun Firebase.initialize(context: Any?, options: FirebaseOptions, name: St | |||
| actual fun Firebase.initialize(context: Any?, options: FirebaseOptions) = | |||
| FirebaseApp(com.google.firebase.FirebaseApp.initializeApp(context as Context, options.toAndroid())) | |||
|
|
|||
| actual class FirebaseApp internal constructor(val android: com.google.firebase.FirebaseApp) { | |||
| actual data class FirebaseApp internal constructor(val android: com.google.firebase.FirebaseApp) { | |||
There was a problem hiding this comment.
So you can do proper equality checks. Useful for testing
I other words: 'Firebase.app("name") == Firebase.app("name")' should return true, as it would on the regular sdks
nbransby
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FirebaseOptions generated on the multiplatform level is missing the GCMSenderId on Android and iOS (on JS it is not used)
This pr fixes that