-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DevouchAttester with multiAttest Support & Fee Recollection #8
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please dm me once comments are resolved. Thanks
|
||
emit Log("attested", gasleft()); | ||
function updateEAS(address newEASAddress) public ownerOnly { | ||
eas = IEAS(newEASAddress); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will EAS Address for a chain change frequently ? If no, why do we need it as a variable?
(bool success, ) = multisig.call{value: address(this).balance}(""); | ||
require(success, "Failed to send Ether"); | ||
emit Log("withdraw", gasleft()); | ||
function withdraw() public ownerOnly { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
anyone in GM should be able to withdraw. We have ensured that no matter who withdraws , the money always goes to multisig.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is Griff's requirement
No description provided.