Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi sig release, 2023-12-31 #25

Merged
merged 47 commits into from
Jan 1, 2024
Merged

Multi sig release, 2023-12-31 #25

merged 47 commits into from
Jan 1, 2024

Conversation

mohammadranjbarz
Copy link
Collaborator

No description provided.

mhmdksh and others added 30 commits August 1, 2023 16:47
@mhmdksh
Update and rename CI-CD.yml to main-pipeline.yml
53d3b00
@mhmdksh
Create develop-pipeline.yml
6625087
@mhmdksh
Create staging-pipeline.yml
632f6da
@mhmdksh
Update develop-pipeline.yml
315ac47
@mhmdksh
Update staging-pipeline.yml
21b72f0
@mhmdksh
Update main-pipeline.yml
321930e
@mhmdksh
Update staging-pipeline.yml
885cca9
@CarlosQ96
add multisig sdk and endpoints
1e77be5
@CarlosQ96
add multisig endpoints for authentication
aa6a93f
@CarlosQ96
remove testing logs and code
b62eccc
@CarlosQ96
Merge pull request #18 from Giveth/gnosis_safe_intergration
f129ef1 
Gnosis safe intregration
@CarlosQ96
update multisig endpoints
ba439c5
@CarlosQ96
fix migration file for multisigSession
d6bba57
@CarlosQ96
unify endpoints for multisig auth
409adaf
@CarlosQ96
remove safe transaction hash
3f8a48d
@CarlosQ96
add more multisig confirmation conditions
b73f5eb
@CarlosQ96
Merge pull request #19 from Giveth/f_new_multisig_message_flow
c62ddc2 
update multisig endpoints
@CarlosQ96
fix multisig query
f42f86a
@CarlosQ96
filter multisig response and db errors
6fb85e7
@CarlosQ96
fix linter
4070b19
@CarlosQ96
fix linter down method in migration
775d3cd
@CarlosQ96
change new api for getting messages from multisig
83d4ef3
@CarlosQ96
save token with correct safeAddress
ddd35fe
@CarlosQ96
add approval expiration logic to multisig endpoint
e3e2ffa
@CarlosQ96
fix migration file for approvalExpirationDate
3e40699
@CarlosQ96
Merge pull request #20 from Giveth/multisig_feedback
490c6f0 
Add approval expiration logic to multisig endpoint
@CarlosQ96
add safeMessageHash to multisig response
3c4ec6c
@CarlosQ96
add multisigSession fetch
32c76cd
@CarlosQ96
fix query params fetch
362d4d5
@CarlosQ96
add lowercase to addresses comparison
c32a0d4
CarlosQ96 and others added 16 commits October 20, 2023 19:00
@CarlosQ96
add orderby CreatedAt for MultisigSession
3320572
@CarlosQ96
return statuses for multisig session
48b3a95
@CarlosQ96
add extra params to response
83b2cc0
@CarlosQ96
fetch multisigmessage in the fetch endpoint
15a4547
@CarlosQ96
add multisig session admin tab
35a33b2
@CarlosQ96
add default user migration for local and staging development
9f92bdd
@CarlosQ96
Merge pull request #21 from Giveth/feature_add_admin_for_multisig_ses…
7639ff4 
…sion

add multisig session admin tab
@aminlatifi
Add .nvmrc
31af76c
@aminlatifi
Support solana authentication
cd7d4b3
@aminlatifi
Remove commented lines
0488921
@aminlatifi
Removed local.env
fabd80a
@aminlatifi
Changed solana authentication parameters
47ed1ff 
* It's not needed to pass whole SWIS payload, only address and nonce are sufficient
@jainkrati
Merge pull request #22 from Giveth/feat/solana_authentication
f35a757 
Support solana authentication
@mhmdksh
Update main-pipeline.yml
c980afa
@CarlosQ96
add safe message time and message validations
231e779
@CarlosQ96
Merge pull request #24 from Giveth/hotfix_multisig_session_state
07c674a 
add safe message time and message validations
@mohammadranjbarz mohammadranjbarz changed the title Next release Multi sig release, 2023-12-31 Dec 31, 2023
CarlosQ96
CarlosQ96 approved these changes Dec 31, 2023
View reviewed changes
Copy link
Collaborator

@CarlosQ96 CarlosQ96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all multisig changes are unrelated to solana, and don't require any additional setup.
Solana is also backward compatible and the same routes remain.
From my point of view its a safe release from auth microservice side!!!!!

@mohammadranjbarz mohammadranjbarz merged commit 3a50e12 into main Jan 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aminlatifi aminlatifi aminlatifi approved these changes

@CarlosQ96 CarlosQ96 CarlosQ96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mohammadranjbarz @aminlatifi @CarlosQ96 @mhmdksh @jainkrati