F 51 refactor event processing #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aminlatifi I had problem on installing dependencies, so I updated giveth bridge dependencies as well |
aminlatifi
reviewed
Sep 1, 2021
| { | ||
| hash: { type: String, required: true, index: true }, | ||
| from: { type: String }, | ||
| gasPrice: { type: Number }, |
There was a problem hiding this comment.
Just fields of hash, blockNumber, isHome and timestamp are needed, plus transactionIndex
There was a problem hiding this comment.
You are right, extra fields removed
@aminlatifi
feathers-src/lib/populate.js
Outdated
| @@ -38,6 +38,9 @@ const processNextWaitingEvent = async () => { | |||
| const query = { | |||
| status: EventStatus.WAITING, | |||
| $sort: { | |||
| // maybe we get some events from home and blockchain with different blockNumber, so the transactionTime | |||
| // should be the first important thing for decide what event should process first | |||
| timestamp: 1, | |||
| isHomeEvent: 1, | |||
There was a problem hiding this comment.
Maybe this one can be removed
There was a problem hiding this comment.
isHomeEvent removed
There was a problem hiding this comment.
Event blockNumber I guess is not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #51