"last uid" is not respected when range and list of user IDs is provided. #10
Conversation
| message_subscribe_send_message('node', $this->node, $message, array(), $subscribe_options); | ||
|
|
||
| // Run cron. | ||
| $this->cronRun(); |
There was a problem hiding this comment.
Thanks for the PR. can we avoid running cron, and invoke the needed function ourself?
|
I have queued to patches to test bot since Travis build fails. @amitaibu I'll update the request if you have any suggestions on how to check for sent emails without using the capture functionality built-in Simpletest. |
|
Tests seem to be failing because Travis needs to be updated - drush should be installed via @ordavidil can you please review. |
|
@capuleto |
| $uids = $subscribe_options['range'] ? array_slice($subscribe_options['uids'], 0, $subscribe_options['range'], TRUE) : $subscribe_options['uids']; | ||
| // If 'last uid' is provided, we need to start from next 'uid' key in array. | ||
| if (!empty($subscribe_options['last uid'])) { | ||
| $index = array_search($subscribe_options['last uid'], array_keys($subscribe_options['uids'])) + 1; |
There was a problem hiding this comment.
Can we live with that assumption ?
You'll have to check, and I don't remember :)
There was a problem hiding this comment.
Message subscribe does not use "last uid" at all when the list of user IDs is provided and range is enabled in subscribe options.
https://www.drupal.org/node/2256899