This repository has been archived by the owner on Aug 18, 2024. It is now read-only.
254 Default argument membership #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MPParsley
commented
Aug 21, 2019
| use Symfony\Component\DependencyInjection\ContainerInterface; | ||
|
|
||
| /** | ||
| * Default argument plugin to provide the group memberships from the current context. |
There was a problem hiding this comment.
Suggested change
| * Default argument plugin to provide the group memberships from the current context. | |
| * Default argument plugin to provide the group memberships from the current | |
| * context. |
MPParsley
commented
Aug 21, 2019
| * The OG context provider. | ||
| * @param \Drupal\og\MembershipManagerInterface $og_membership | ||
| * The OG membership manager. | ||
| * @param \Drupal\Core\Session\AccountInterface $og_user |
There was a problem hiding this comment.
Suggested change
| * @param \Drupal\Core\Session\AccountInterface $og_user | |
| * @param \Drupal\Core\Session\AccountInterface $user |
MPParsley
commented
Aug 21, 2019
| * @param \Drupal\Core\Session\AccountInterface $og_user | ||
| * The user to be evaluated. | ||
| */ | ||
| public function __construct(array $configuration, $plugin_id, $plugin_definition, ContextProviderInterface $og_context, MembershipManagerInterface $og_membership, AccountInterface $og_user) { |
There was a problem hiding this comment.
Suggested change
| public function __construct(array $configuration, $plugin_id, $plugin_definition, ContextProviderInterface $og_context, MembershipManagerInterface $og_membership, AccountInterface $og_user) { | |
| public function __construct(array $configuration, $plugin_id, $plugin_definition, ContextProviderInterface $og_context, MembershipManagerInterface $og_membership, AccountInterface $user) { |
MPParsley
commented
Aug 21, 2019
|
|
||
| $this->ogContext = $og_context; | ||
| $this->ogMembership = $og_membership; | ||
| $this->ogUser = $og_user; |
There was a problem hiding this comment.
Suggested change
| $this->ogUser = $og_user; | |
| $this->ogUser = $user; |
MPParsley
commented
Aug 21, 2019
| */ | ||
| public function getCacheContexts() { | ||
| // This cache context is the best thing we have right now. | ||
| // og_role takes in consideration the user memberships and |
There was a problem hiding this comment.
Suggested change
| // og_role takes in consideration the user memberships and | |
| // og_role takes in consideration the user memberships and |
MPParsley
commented
Aug 21, 2019
| public function getCacheContexts() { | ||
| // This cache context is the best thing we have right now. | ||
| // og_role takes in consideration the user memberships and | ||
| // the roles held in the corresponding groups, and while it |
There was a problem hiding this comment.
Suggested change
| // the roles held in the corresponding groups, and while it | |
| // the roles held in the corresponding groups, and while it |
MPParsley
commented
Aug 21, 2019
| // This cache context is the best thing we have right now. | ||
| // og_role takes in consideration the user memberships and | ||
| // the roles held in the corresponding groups, and while it | ||
| // is one level too granular, i.e. the context will be more |
There was a problem hiding this comment.
Suggested change
| // is one level too granular, i.e. the context will be more | |
| // is one level too granular, i.e. the context will be more |
MPParsley
commented
Aug 21, 2019
| * An array of groups, or an empty array if no group is found. | ||
| */ | ||
| protected function getCurrentUserGroupIds($entity_type = 'node') { | ||
| $groups = $this->ogMembership->getUserGroupIds($this->ogUser); |
There was a problem hiding this comment.
Suggested change
| $groups = $this->ogMembership->getUserGroupIds($this->ogUser); | |
| $groups = $this->ogMembership->getUserGroupIds($this->ogUser->id()); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging tombola:default-argument-membership into gizra/og