Add ListMissingOneImplCounts spanner method #876
+892
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcscottiii
force-pushed
the
jcscottiii/missing-one-impl
branch
from
0f91b4b
to
1dc4916
Compare
jcscottiii
force-pushed
the
jcscottiii/store-events-methods
branch
from
087bdda
to
352b19a
Compare
jcscottiii
force-pushed
the
jcscottiii/missing-one-impl
branch
from
1dc4916
to
96a304b
Compare
jcscottiii
force-pushed
the
jcscottiii/missing-one-impl
branch
from
96a304b
to
d542bc9
Compare
This is the spanner method that will power the missing one implementation graph. It uses the pre calculated results from the BrowserFeatureSupportEvents table. Features: - It allows the caller to pass in arbitrary set of browsers to compare against. - It has a string pagination token that is decoded and used to continue paging for results - It returns the results in DESC order of the Release Date This method is similar to: 1. the [ListMetricsForFeatureIDBrowserAndChannel](https://github.com/GoogleChrome/webstatus.dev/blob/dd754efe5e2fa27cc80542fbacd41886e765b7ba/lib/gcpspanner/wpt_run_feature_metric.go#L418-L494) method used to get the results for the WPT metrics that power the chart on the feature detail, and 2. the [ListBrowserFeatureCountMetric](https://github.com/GoogleChrome/webstatus.dev/blob/dd754efe5e2fa27cc80542fbacd41886e765b7ba/lib/gcpspanner/browser_feature_count.go#L38C18-L105) method used to get the results for the feature count that power the chart on the stats page This PR is a split up of https://github.com/GoogleChrome/webstatus.dev/compare/missing-one-impl-count-db?expand=1 Fixes #864 Depends on #872
jcscottiii
force-pushed
the
jcscottiii/missing-one-impl
branch
from
d542bc9
to
cecc54b
Compare
jrobbins
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the spanner method that will power the missing one implementation graph.
It uses the pre calculated results from the BrowserFeatureSupportEvents table.
Features:
This method is similar to:
This PR is a split up of https://github.com/GoogleChrome/webstatus.dev/compare/missing-one-impl-count-db?expand=1
Fixes #864
Depends on #872