[secure-boot] merge changes from init-actions #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cjac
commented
Oct 30, 2024
cjac
commented
- include metadata when performing compute instance create
- --trusted-cert is only used to disable shielded-secure-boot
- reduce noise in installer ; also put long job timer and log redirection in execute_with_retries
- installer dir is pointed to by ${tmpdir}
- require 10.5G of free memory before using the ramdisk acceleration
… performing compute instance create
…--tmpdir argument now
README.md * clarified that passing an empty string to --trusted-cert will disable secure-boot custom_image_utils/shell_script_generator.py * execute_with_retries reduces log noise and emits timing information * inject secret metadata unless --trusted-cert="" is passed examples/secure-boot/build-current-images.sh * using ceil to round up in disk usage analysis perl script * example of calling perl script cleaned up a little examples/secure-boot/install_gpu_driver.sh examples/secure-boot/dask.sh examples/secure-boot/rapids.sh * matched exit_handler implementations between the three of the above * collect disk usage information * disk sizes are collected in 1k pages instead of human-readable * mounting ram disk at /tmp to reduce disk usage further examples/secure-boot/pre-init.sh * removed metadata from arguments, since it will be injected in the generated script * passing creating-image metadata to zero disk before and after run * updated disk sizes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.