Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template docs #1966

Merged
merged 7 commits into from
Oct 30, 2024
Merged

Conversation

liferoad
Copy link
Contributor

@liferoad liferoad commented Oct 28, 2024

Fixes #1907

Ran to update all the template docs:

mvn clean prepare-package \
  -DskipTests \
  -PtemplatesSpec

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.08%. Comparing base (f09e241) to head (6ed5c54).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1966      +/-   ##
============================================
- Coverage     45.09%   45.08%   -0.02%     
- Complexity     3611     3934     +323     
============================================
  Files           835      835              
  Lines         49708    49708              
  Branches       5234     5234              
============================================
- Hits          22417    22412       -5     
- Misses        25625    25629       +4     
- Partials       1666     1667       +1     
Components Coverage Δ
spanner-templates 66.25% <ø> (-0.02%) ⬇️
spanner-import-export 64.16% <ø> (-0.05%) ⬇️
spanner-live-forward-migration 76.18% <ø> (ø)
spanner-live-reverse-replication 76.54% <ø> (ø)
spanner-bulk-migration 85.57% <ø> (ø)
Files with missing lines Coverage Δ
...ogle/cloud/teleport/templates/PubSubToDatadog.java 22.40% <ø> (ø)

... and 2 files with indirect coverage changes

Copy link
Contributor

@Polber Polber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Contributor

@damondouglas damondouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liferoad LGTM

@liferoad
Copy link
Contributor Author

I am going to merge this now.

@liferoad liferoad merged commit bd69fa2 into GoogleCloudPlatform:main Oct 30, 2024
25 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Allow specifying withQueryTempDataset for the BQ query
3 participants