Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update terraform modules via plugin #1976

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

damondouglas
Copy link
Contributor

Applied the following commands to update the repository's Terraform modules:

  1. Installed the maven plugins:
mvn clean install -pl plugins/templates-maven-plugin -am
  1. Ran the maven command to update/generate the repository's Terraform modules:
mvn clean prepare-package \
  -DskipTests \
  -PtemplatesTerraform
  1. Ran the Terraform command to format the hcl code:

For the legacy templates:

terraform fmt -recursive v1

For the flex templates:

terraform fmt -recursive v2

See contributor-docs/code-contributions for more details.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.31%. Comparing base (b72eaa2) to head (f2fadef).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1976      +/-   ##
============================================
+ Coverage     45.09%   48.31%   +3.22%     
+ Complexity     3935     1334    -2601     
============================================
  Files           835      410     -425     
  Lines         49703    22321   -27382     
  Branches       5232     2228    -3004     
============================================
- Hits          22412    10784   -11628     
+ Misses        25625    10866   -14759     
+ Partials       1666      671     -995     
Components Coverage Δ
spanner-templates 67.29% <ø> (+1.01%) ⬆️
spanner-import-export ∅ <ø> (∅)
spanner-live-forward-migration 76.18% <ø> (ø)
spanner-live-reverse-replication 76.54% <ø> (ø)
spanner-bulk-migration 85.57% <ø> (ø)

see 443 files with indirect coverage changes

EOT
default = "part"
default = null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's strange that the default is now null, when the comment (and the code, if I remember correctly) have "part" as the default

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generator is setup assuming either defaulted or optional, not defaulted and optional. I moved this PR to draft to fix this. Thanks for calling this out.

EOT
default = "part"
default = null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@damondouglas damondouglas marked this pull request as draft November 1, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants