-
Notifications
You must be signed in to change notification settings - Fork 967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update terraform modules via plugin #1976
base: main
Are you sure you want to change the base?
Update terraform modules via plugin #1976
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1976 +/- ##
============================================
+ Coverage 45.09% 48.31% +3.22%
+ Complexity 3935 1334 -2601
============================================
Files 835 410 -425
Lines 49703 22321 -27382
Branches 5232 2228 -3004
============================================
- Hits 22412 10784 -11628
+ Misses 25625 10866 -14759
+ Partials 1666 671 -995
|
EOT | ||
default = "part" | ||
default = null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's strange that the default is now null, when the comment (and the code, if I remember correctly) have "part" as the default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The generator is setup assuming either defaulted or optional, not defaulted and optional. I moved this PR to draft to fix this. Thanks for calling this out.
EOT | ||
default = "part" | ||
default = null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
Applied the following commands to update the repository's Terraform modules:
For the legacy templates:
For the flex templates:
See contributor-docs/code-contributions for more details.