GKE Core platform updates and enhancements #82
Conversation
arueth
requested review from
ferrarimarco,
laurentgrangeau,
kenthua and
gushob21
| node_config { | ||
| machine_type = "e2-standard-4" | ||
| machine_type = var.cluster_system_node_pool_machine_type | ||
| service_account = google_service_account.cluster.email |
There was a problem hiding this comment.
Is it possible to have a variable here and use google_service_account.cluster.email is the user didn't specify anything? This will be useful for the federated learning use case
| node_config { | ||
| machine_type = "e2-standard-4" | ||
| machine_type = var.cluster_system_node_pool_machine_type |
There was a problem hiding this comment.
Just checking: we're reusing the same variable as we're using in the system node pool below.
| location = var.cluster_region | ||
| name = local.cluster_name | ||
| project = var.cluster_project_id | ||
| node_config { |
There was a problem hiding this comment.
Is it possible to add variables to specify custom labels and taints for this node pool? This will be useful for the federated learning use case.
| "resource-type" : "system" | ||
| } | ||
| machine_type = var.cluster_system_node_pool_machine_type | ||
| service_account = google_service_account.cluster.email |
There was a problem hiding this comment.
Is it possible to have a variable here and use google_service_account.cluster.email is the user didn't specify anything? This will be useful for the federated learning use case
| "https://www.googleapis.com/auth/cloud-platform" | ||
| ] | ||
|
|
||
| # Blocks |
There was a problem hiding this comment.
Can we add blocks and vars to configure labels and taints? These are going to be useful for the federated learning use case. Thanks
No description provided.