Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kueue default config defined #3378

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ighosh98
Copy link
Contributor

@ighosh98 ighosh98 commented Dec 10, 2024

Submission Checklist

A default kueue config for TAS workloads was defined that can help customers get started with using Kueue with cluster toolkit. You can add the following to the template of your choice to use the blueprint under kueue configs.

        version: v0.10.0
        config_path:  $(ghpc_stage("kueue-config-files"))/kueue-default-configuration.yaml.tftpl
        config_template_vars: {nodepool_name: "a3-highgpu-8g-a3highgpupool"}

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@ighosh98 ighosh98 added the release-key-new-features Added to release notes under the "Key New Features" heading. label Dec 10, 2024
@mwysokin
Copy link

LGTM 🖖
...from the Kueue perspective.

FYI We'll need to make a small change once 0.10.0 comes out to add tolerations to the resource flavor, but that's not needed for 0.9.1 without rank ordering.

Thank you for working on this 🙏

@ighosh98
Copy link
Contributor Author

LGTM 🖖 ...from the Kueue perspective.

FYI We'll need to make a small change once 0.10.0 comes out to add tolerations to the resource flavor, but that's not needed for 0.9.1 without rank ordering.

Thank you for working on this 🙏

Thanks! We would update the config once 0.10.0 comes in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-key-new-features Added to release notes under the "Key New Features" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants