Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: withstand connect storms #1414

Open
wants to merge 4 commits into
base: postgresql-dialect
Choose a base branch
from

Conversation

olavloite
Copy link
Collaborator

Use a background worker thread pool to create new connections. This reduces the probability that the client will timeout while waiting for a connection, when a large number of connections are being requested at the same time.

Fixes #1377

Use a background worker thread pool to create new connections. This
reduces the probability that the client will timeout while waiting for a
connection, when a large number of connections are being requested at
the same time.

Fixes #1377
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.63%. Comparing base (0a78cf6) to head (4493cc5).
Report is 762 commits behind head on postgresql-dialect.

Files with missing lines Patch % Lines
...om/google/cloud/spanner/pgadapter/ProxyServer.java 72.72% 3 Missing ⚠️
...gle/cloud/spanner/pgadapter/ConnectionHandler.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                   Coverage Diff                    @@
##             postgresql-dialect    #1414      +/-   ##
========================================================
- Coverage                 90.66%   90.63%   -0.03%     
- Complexity                 2640     2642       +2     
========================================================
  Files                       141      141              
  Lines                      9016     9030      +14     
  Branches                   1313     1314       +1     
========================================================
+ Hits                       8174     8184      +10     
- Misses                      567      570       +3     
- Partials                    275      276       +1     
Flag Coverage Δ
all_tests 90.63% <73.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PGAdapter seems to refuse connections during a connect storm
1 participant