Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mksqsh: add initial table writer implementation. #224

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Gottox
Copy link
Owner

@Gottox Gottox commented Apr 27, 2024

No description provided.

Copy link

codecov bot commented Apr 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 76 lines in your changes missing coverage. Please review.

Project coverage is 63.05%. Comparing base (11a8378) to head (1926e07).
Report is 123 commits behind head on main.

Current head 1926e07 differs from pull request most recent head 31a1d0a

Please upload reports for the commit 31a1d0a to get more accurate results.

Files Patch % Lines
libmksqsh/src/table/table_builder.c 0.00% 50 Missing ⚠️
libmksqsh/src/table/fragment_table_builder.c 0.00% 12 Missing ⚠️
libmksqsh/src/table/id_table_builder.c 0.00% 10 Missing ⚠️
common/src/data/fragment_set.c 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #224      +/-   ##
==========================================
- Coverage   63.94%   63.05%   -0.90%     
==========================================
  Files          72       76       +4     
  Lines        5337     5413      +76     
  Branches      772      781       +9     
==========================================
  Hits         3413     3413              
- Misses       1496     1572      +76     
  Partials      428      428              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gottox Gottox force-pushed the add/table_support branch 3 times, most recently from 838f150 to 1926e07 Compare April 27, 2024 16:43
Copy link

sonarcloud bot commented Jun 9, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Repository owner deleted a comment from sonarcloud bot Jun 9, 2024
Copy link

sonarcloud bot commented Aug 10, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant