Optimize sqsh_tree_traversal_path_dup
#271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compute the size, and allocate only once with the exact size. Build the path in reverse while walking the traversal stack, which avoids the need to call `sqsh_tree_traversal_path_segment` repeatedly (which must walk the traversal stack on each call)
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #271 +/- ##
==========================================
+ Coverage 64.57% 64.80% +0.23%
==========================================
Files 74 74
Lines 5518 5532 +14
Branches 828 829 +1
==========================================
+ Hits 3563 3585 +22
+ Misses 1474 1469 -5
+ Partials 481 478 -3 ☔ View full report in Codecov by Sentry. |
|
Great addition! - Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compute the size, and allocate only once with the exact size. Build the path in reverse while walking the traversal stack, which avoids the need to call
sqsh_tree_traversal_path_segmentrepeatedly (which must walk the traversal stack on each call).In a simple benchmark (repeatedly calling
sqsh_easy_tree_traversalagainst a simple squashfs file), this makes the entiresqsh_easy_tree_traversalcall about 16% faster.