-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reader: reimplementation the reader without _skip #39
Commits on Aug 16, 2023
-
Revert "buffer: remove unused _drain method"
This reverts commit b3f42f9.
Configuration menu - View commit details
-
Copy full SHA for 4a7dccb - Browse repository at this point
Copy the full SHA 4a7dccbView commit details
Commits on Aug 17, 2023
-
reader: reimplementation the reader without _skip
Currently, there is an issue with a subtle incompatibility between different iterators. The old SqshReader expected, that all blocks (except the last one) are of the same size. This is not true for SqshFileIterator when iterating over sparse files. The new SqshReader2 does not have this limitation.
Configuration menu - View commit details
-
Copy full SHA for 6dd6db6 - Browse repository at this point
Copy the full SHA 6dd6db6View commit details -
Configuration menu - View commit details
-
Copy full SHA for e95347e - Browse repository at this point
Copy the full SHA e95347eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6757ae7 - Browse repository at this point
Copy the full SHA 6757ae7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 82cd5ed - Browse repository at this point
Copy the full SHA 82cd5edView commit details -
reader: fix when end offset aligns with block end
This fixes a bug when the data storage wrongfully points to the iterator when it actually needs to read from the buffer. A safeguard `assert()` call has been added to the `reader_fill_buffer()` to detect this error in case of regression. Also a test case has been added to reproduce this error.
Configuration menu - View commit details
-
Copy full SHA for c336b2e - Browse repository at this point
Copy the full SHA c336b2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d94e415 - Browse repository at this point
Copy the full SHA d94e415View commit details -
Configuration menu - View commit details
-
Copy full SHA for d5dc3ad - Browse repository at this point
Copy the full SHA d5dc3adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1393fb0 - Browse repository at this point
Copy the full SHA 1393fb0View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.