Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reader: reimplementation the reader without _skip #39

Merged
merged 9 commits into from
Aug 17, 2023
Merged

reader: reimplementation the reader without _skip #39

merged 9 commits into from
Aug 17, 2023

Commits on Aug 16, 2023

  1. Revert "buffer: remove unused _drain method"

    This reverts commit b3f42f9.
    Gottox committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    4a7dccb View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. reader: reimplementation the reader without _skip

    Currently, there is an issue with a subtle incompatibility between
    different iterators. The old SqshReader expected, that all blocks
    (except the last one) are of the same size. This is not true for
    SqshFileIterator when iterating over sparse files. The new
    SqshReader2 does not have this limitation.
    Gottox committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    6dd6db6 View commit details
    Browse the repository at this point in the history
  2. file_reader: use SqshReader2.

    Gottox committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    e95347e View commit details
    Browse the repository at this point in the history
  3. map_reader: use SqshReader2.

    Gottox committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    6757ae7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    82cd5ed View commit details
    Browse the repository at this point in the history
  5. reader: fix when end offset aligns with block end

    This fixes a bug when the data storage wrongfully points to the iterator
    when it actually needs to read from the buffer.
    
    A safeguard `assert()` call has been added to the `reader_fill_buffer()`
    to detect this error in case of regression. Also a test case has been
    added to reproduce this error.
    Gottox committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    c336b2e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d94e415 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d5dc3ad View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    1393fb0 View commit details
    Browse the repository at this point in the history