Use locale formatting where possible in WAILA and The One Probe #2327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josiah-roberts
force-pushed
the
use-locale-formatting-for-consume-produce
branch
from
aa448c5
to
0353ee0
Compare
htmlcsjs
approved these changes
Dec 29, 2023
serenibyss
pushed a commit
that referenced
this pull request
Jan 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I noticed that The One Probe and WAILA tooltips and don't use locale formatting for their production and consumption the same way that JEI recipes (and most other parts of the mod) do.
Implementation Details
I took a pass throught the WAILA and The One Probe integrations and updated them to use
TextFormattingUtil.formatNumberswherever a number might conceivably become large. This should use the the default locale.Outcome
Numbers are now locale formatted.
Additional Information
Before:
After:
Potential Compatibility Issues
Just addressing a localization issue, so shouldn't cause any compat issues.