Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port/Rework Crafting Station to MUI2 #2455

Open
wants to merge 117 commits into
base: master
Choose a base branch
from

Conversation

ghzdude
Copy link
Contributor

@ghzdude ghzdude commented Apr 17, 2024

What

the fabled pr that ports the crashing Crafting Station to cleanroom mui, and also reworks the crafting station logic.
i now believe it is feature complete and ready for review

Implementation Details

rework crafting station logic
port crafting station to mui2

Todo/Notes

  • crafting grid - essentially complete
    • JEI transfer complete
    • should probably not be specific to the crafting station
    • no longer extends itemslot
  • output slot
    • no longer extends itemslot, syncing and interaction is handled manually
  • recipe memory slots
    • effectively feature complete
  • inventory tab - essentially complete
    • should correctly update and handle when inventories are added/removed

Outcome

crafting station will continue to exist

@ghzdude ghzdude added the type: feature New feature or request label Apr 17, 2024
@ghzdude ghzdude force-pushed the gh-crafting-station-mui-port branch from 270a020 to 85a5c84 Compare April 20, 2024 21:20
@ghzdude ghzdude marked this pull request as ready for review May 3, 2024 18:51
@ghzdude ghzdude requested review from a team as code owners May 3, 2024 18:51
@bruberu
Copy link
Member

bruberu commented Jun 4, 2024

To summarize a few things I found in an in-game review that would be good to have before I go all-in with reviewing 19 files:

  • Re-implement the red tint on top of missing items
  • Use the correct tool slot overlay
  • Add an output stack amount indicator
  • Allow JEI shortcuts on all of the different ghost slots
  • Prevent unlocked items in recipe memory from at least getting immediately overwritten
  • Remove unused classes from the pre-MUI widget system-
  • Move datacodes to the correct file
  • Fix the lock icon rendering under the items
  • Resolve the "tool damage" TODO (and in fact process all item crafting behaviors, such as that of buckets)
  • Re-implement shift-clicking behavior

@ghzdude ghzdude force-pushed the gh-crafting-station-mui-port branch from d88f038 to 1558a94 Compare October 17, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
Status: Hard
Development

Successfully merging this pull request may close these issues.

2 participants