-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port/Rework Crafting Station to MUI2 #2455
Open
ghzdude
wants to merge
117
commits into
GregTechCEu:master
Choose a base branch
from
ghzdude:gh-crafting-station-mui-port
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Port/Rework Crafting Station to MUI2 #2455
ghzdude
wants to merge
117
commits into
GregTechCEu:master
from
ghzdude:gh-crafting-station-mui-port
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghzdude
force-pushed
the
gh-crafting-station-mui-port
branch
from
April 20, 2024 21:20
270a020
to
85a5c84
Compare
To summarize a few things I found in an in-game review that would be good to have before I go all-in with reviewing 19 files:
|
ghzdude
force-pushed
the
gh-crafting-station-mui-port
branch
2 times, most recently
from
June 9, 2024 19:46
f528df5
to
07a2377
Compare
ghzdude
force-pushed
the
gh-crafting-station-mui-port
branch
from
July 20, 2024 17:24
2c0f220
to
f4e1615
Compare
ghzdude
force-pushed
the
gh-crafting-station-mui-port
branch
from
August 25, 2024 06:53
9914d3b
to
6160fd7
Compare
add crafting amount to ui
add method to update handler
make the stack lookup map into a cache make recipe logic reference the input slots instead of vice versa improve `detectAndSendChanges()` a bit
use set for stack lookup instead of list rearrange methods and add some javadocs fix slot highlighting from changes handle container items (drums, etc) correctly
that why shift was broken
ghzdude
force-pushed
the
gh-crafting-station-mui-port
branch
from
October 17, 2024 00:13
d88f038
to
1558a94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
the fabled pr that ports the
crashingCrafting Station to cleanroom mui, and also reworks the crafting station logic.i now believe it is feature complete and ready for review
Implementation Details
rework crafting station logic
port crafting station to mui2
Todo/Notes
Outcome
crafting station will continue to exist