Rework Filters as Cover and Fluid Pipes with Covers #2640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix issues with logic add lang
bruberu
approved these changes
Oct 16, 2024
improve comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
add an "allow flow" button for filters as covers that is only shown when on Filter Drain or Fill
prevent fluid pipes from pushing at all through a fluid pump
Implementation Details
reworked the filtered handler in the item/fluid filter cover to make sense
Outcome
inserting through a filter set to filter extract is possible
you don't need to disconnect pumps to ensure the pump is the only thing transferring fluid