Fix Issues with Transporting Some Items to Some Inventories #2648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IntegerLimit
changed the title
TechLord22
approved these changes
Nov 10, 2024
TechLord22
added
type: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR fixes issues with transporting items with a stack size of 1, via pipe or conveyor, into special inventories, such as Super/Quantum Chests or Storage Drawers.
Fixes Nomi-CEu/Nomi-CEu#420
Implementation Details
This PR simply removes the check in
GTTransferUtils.insertItemfor whether the item is not stackable, as these special inventories only have one slot, but can insert more than the typical item stack size in said slot.Outcome
Fixes Nomi-CEu/Nomi-CEu#420
Additional Information
Implemented in Labs here: Nomi-CEu/Nomi-Labs@29fe265
Potential Compatibility Issues
None