Small access restriction change in order to create a fluid hatch subclass #2654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruberu
approved these changes
Nov 2, 2024
|
If this was done for fluid hatches specifically, shouldn't this also be done for item buses, to allow development of similar-ish features and/or mods in the future? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Allows a separate hatch subclass to be made for the GregTech-based rocketry mod. This class should be able to represent how filled a fuel tank is and determine its own capacity based on block structures.
Outcome
The methods and attributes of MetaTileEntityFluidHatch are now all protected, rather than private. Once this pull request is accepted, I will be able to move on with development of the mod.