Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metric engine): label mismatch in metric engine #3927

Merged
merged 6 commits into from
May 14, 2024

Conversation

v0y4g3r
Copy link
Contributor

@v0y4g3r v0y4g3r commented May 13, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This PR fixes the issue where the same primary key gets wrong pk index when dict_builder is frozen. The root cause can be found here.

Performance

This PR has little impaction to the ingestion performance of metric engine.
Snipaste_2024-05-13_20-05-48

Snipaste_2024-05-13_20-05-53

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 13, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 99.08257% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 85.45%. Comparing base (9d12496) to head (34ff396).
Report is 9 commits behind head on main.

❗ Current head 34ff396 differs from pull request most recent head 81afee6. Consider uploading reports for the commit 81afee6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3927      +/-   ##
==========================================
- Coverage   85.96%   85.45%   -0.51%     
==========================================
  Files         963      967       +4     
  Lines      164580   166172    +1592     
==========================================
+ Hits       141481   142008     +527     
- Misses      23099    24164    +1065     

@v0y4g3r v0y4g3r requested a review from evenyag May 14, 2024 03:20
@v0y4g3r v0y4g3r changed the title fix: label mismatch in metric engine fix(metric engine): label mismatch in metric engine May 14, 2024
@v0y4g3r v0y4g3r requested a review from fengjiachun May 14, 2024 09:17
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/mito2/src/memtable/partition_tree/dict.rs Show resolved Hide resolved
src/mito2/src/test_util/memtable_util.rs Show resolved Hide resolved
src/mito2/src/memtable/partition_tree.rs Outdated Show resolved Hide resolved
src/mito2/src/memtable/partition_tree/dict.rs Outdated Show resolved Hide resolved
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fascinating!

@v0y4g3r v0y4g3r enabled auto-merge May 14, 2024 12:44
@v0y4g3r v0y4g3r added this pull request to the merge queue May 14, 2024
Merged via the queue into GreptimeTeam:main with commit c04d024 May 14, 2024
21 checks passed
@v0y4g3r v0y4g3r deleted the fix/label-mismatch branch May 14, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect label saved when writing metrics with prometheus remote write after flush memtables
4 participants