Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: try to fix unstable fuzz test #4003

Merged
merged 1 commit into from
May 21, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented May 21, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

  1. ignore PoolTimedOut error for now

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@WenyXu WenyXu requested a review from a team as a code owner May 21, 2024 09:00
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 21, 2024
@fengjiachun
Copy link
Collaborator

Set acquire_timeout to 60s

Can you explain why you do this?

@WenyXu
Copy link
Member Author

WenyXu commented May 21, 2024

Set acquire_timeout to 60s

Can you explain why you do this?

Good catch, it seems we don't need to change this value.

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.18%. Comparing base (d7ade3c) to head (3afdb3e).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4003      +/-   ##
==========================================
- Coverage   85.48%   85.18%   -0.31%     
==========================================
  Files         977      977              
  Lines      169348   169344       -4     
==========================================
- Hits       144773   144261     -512     
- Misses      24575    25083     +508     

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WenyXu WenyXu added this pull request to the merge queue May 21, 2024
Merged via the queue into GreptimeTeam:main with commit 43bf7bf May 21, 2024
32 checks passed
@WenyXu WenyXu deleted the fix/unstable-fuzz-test branch May 21, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants