Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error in admin function is not formatted properly #4820

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Prior to this change, the error is something like

MySQL [(none)]> admin flush_table(phy);
ERROR 1210 (HY000): (InvalidArguments): Failed to build admin function args: unsupported function arg {arg}

which doesn't format arg in error message.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@waynexia waynexia requested a review from a team as a code owner October 11, 2024 09:47
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Oct 11, 2024
Copy link
Member

@WenyXu WenyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.17%. Comparing base (7dd0e3a) to head (aeb9887).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4820      +/-   ##
==========================================
- Coverage   84.42%   84.17%   -0.26%     
==========================================
  Files        1125     1125              
  Lines      204866   204866              
==========================================
- Hits       172967   172439     -528     
- Misses      31899    32427     +528     

@killme2008 killme2008 added this pull request to the merge queue Oct 11, 2024
Merged via the queue into GreptimeTeam:main with commit a61c0bd Oct 11, 2024
35 checks passed
@waynexia waynexia deleted the fix-admin-formatter branch October 11, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants