Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(metric name): support multiple __name__ matcher #71

Merged
merged 5 commits into from
Jul 10, 2023
Merged

fix(metric name): support multiple __name__ matcher #71

merged 5 commits into from
Jul 10, 2023

Conversation

yuanbohan
Copy link
Contributor

fix #70

@yuanbohan yuanbohan requested a review from waynexia July 7, 2023 16:05
@codecov
Copy link

codecov bot commented Jul 7, 2023 •
edited
Loading

Codecov Report

Merging #71 (52b7087) into main (0bbdb3f) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head 52b7087 differs from pull request most recent head 6cd29f7. Consider uploading reports for the commit 6cd29f7 to get more accurate results

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   98.68%   98.63%   -0.05%     
==========================================
  Files          12       12              
  Lines        5093     4924     -169     
==========================================
- Hits         5026     4857     -169     
  Misses         67       67
Impacted Files Coverage Δ
src/label/matcher.rs 100.00% <100.00%> (ø)
src/parser/ast.rs Critical 95.04% <100.00%> (-0.06%) ⬇️
src/parser/parse.rs Critical 99.95% <100.00%> (-0.01%) ⬇️

@yuanbohan yuanbohan changed the title Fix: metric name twice bug Fix!: metric name twice bug Jul 7, 2023
@yuanbohan yuanbohan changed the title Fix!: metric name twice bug Fix(metric name): twice bug Jul 7, 2023
@yuanbohan yuanbohan changed the title Fix(metric name): twice bug fix(metric name): twice bug Jul 7, 2023
@yuanbohan yuanbohan mentioned this pull request Jul 7, 2023
Merged
@yuanbohan yuanbohan requested a review from evenyag July 7, 2023 16:34
@yuanbohan yuanbohan changed the title fix(metric name): twice bug fix(metric name): support multiple __name__ matcher Jul 7, 2023
waynexia
waynexia approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Show resolved Hide resolved
evenyag
evenyag approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does greptimedb's prom planner assume that the __name__ matcher must be present? This PR might break this assumption. @waynexia

@yuanbohan
Copy link
Contributor Author

LGTM. Does greptimedb's prom planner assume that the __name__ matcher must be present? This PR might break this assumption. @waynexia

Yes，be careful to upgrade to 0.1.3 @waynexia

@waynexia
Copy link
Member

LGTM. Does greptimedb's prom planner assume that the __name__ matcher must be present? This PR might break this assumption. @waynexia

Yes，be careful to upgrade to 0.1.3 @waynexia

👍 I'll add related tests when upgrading

@waynexia waynexia merged commit 7213b6c into main Jul 10, 2023
7 checks passed
@waynexia waynexia deleted the fix-metric-name-twice-bug branch July 10, 2023 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evenyag evenyag evenyag approved these changes

@waynexia waynexia waynexia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple __name__ matchers not permitted
3 participants
@yuanbohan @waynexia @evenyag