Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: try_parse_re for repetition logic #79

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Conversation

yuanbohan
Copy link
Contributor

@yuanbohan yuanbohan commented Nov 9, 2023

what's included

  • make escaping { for repetition logic cleaner, and only try_parse_re when Err happens
  • bump version to 0.3.1
  • clippy including tests

cc @fbs

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6d752e7) 98.90% compared to head (c021908) 98.90%.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
- Coverage   98.90%   98.90%   -0.01%     
==========================================
  Files          14       14              
  Lines        6215     6202      -13     
==========================================
- Hits         6147     6134      -13     
  Misses         68       68              
Files Coverage Δ
src/label/matcher.rs 100.00% <100.00%> (ø)
src/parser/ast.rs Critical 97.88% <100.00%> (ø)
src/parser/lex.rs Critical 98.02% <100.00%> (-0.02%) ⬇️
src/parser/parse.rs Critical 100.00% <100.00%> (ø)
src/parser/token.rs 100.00% <100.00%> (ø)
src/util/number.rs 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@fbs fbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia merged commit b189242 into main Nov 10, 2023
8 checks passed
@waynexia waynexia deleted the refactor-convert-re branch November 10, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants