Add unit tests, static methods to instance methods, interface for HTTP client #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The kid is onw of the publicly known kid's Apple publishes at https://appleid.apple.com/auth/keys
require phpunit for tests
- Remove dependency on \AppleSignIn\JWK, use underlying functionality from Firebase library. - Tests now pass.
Fix PSR-2 code violations
I want to see this work / how this workss
They are not used or needed here. We are decorating the underlying decoded JWT stdClass/Object and wish to provide getters.
We expect to recieve a subject and email claim from apple, error if we don't recieve them..
I should break the inheritence sometime in the future
previewing changes before PR to upstream
Remove main.yml and 2nd github actions workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know if you like the direction I have taken here or not, and if you want to work to get changes merge back into this repo :)
What ?
Change most static methods to instance methods
Introduce an interface for HTTP client (It may be better to use the HTTP Message interfaces from PSR-7 here now that I write this).
Add (some) unit and integration tests.
Includes changes from #16
Why ?
Implement a caching HTTP client to store the public key response from apple for some time in redis. Static method calls to the Curl implementation or file_get_contents makes this challenging. I can contribute this back to the repo, I intend to use Guzzle and a Guzzle Caching middle-ware.
Write unit and integration tests for the library.
Use the library as a dependency instead as static method calls, and mock it out in calling code tests. I could write a wrapper around the library to achieve this, but that would not allow caching the Apple cert HTTP call.