All HitBox and CollisionBox Changes made for LineOfSightPlace #1725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently out of date, need to backport some changes made for LOSP. |
|
This branch is now up to date with all simulation-related (hitbox and collisionbox) bugfixes and changes made while writing LOSP. Feel free to review and merge |
ManInMyVan
suggested changes
Sep 30, 2024
src/main/java/ac/grim/grimac/utils/collisions/CollisionData.java
Outdated
Show resolved
Hide resolved
src/main/java/ac/grim/grimac/utils/collisions/CollisionData.java
Outdated
Show resolved
Hide resolved
# Conflicts: # src/main/java/ac/grim/grimac/utils/collisions/CollisionData.java
ManInMyVan
suggested changes
Oct 3, 2024
src/main/java/ac/grim/grimac/utils/collisions/blocks/connecting/DynamicCollisionWall.java
Outdated
Show resolved
Hide resolved
src/main/java/ac/grim/grimac/utils/collisions/CollisionData.java
Outdated
Show resolved
Hide resolved
src/main/java/ac/grim/grimac/utils/collisions/CollisionData.java
Outdated
Show resolved
Hide resolved
src/main/java/ac/grim/grimac/utils/collisions/CollisionData.java
Outdated
Show resolved
Hide resolved
Co-authored-by: ManInMyVan <[email protected]>
Co-authored-by: ManInMyVan <[email protected]>
Co-authored-by: ManInMyVan <[email protected]>
Co-authored-by: ManInMyVan <[email protected]>
Co-authored-by: ManInMyVan <[email protected]>
Co-authored-by: ManInMyVan <[email protected]>
Co-authored-by: ManInMyVan <[email protected]>
Co-authored-by: ManInMyVan <[email protected]>
Co-authored-by: ManInMyVan <[email protected]>
Co-authored-by: ManInMyVan <[email protected]>
Co-authored-by: ManInMyVan <[email protected]>
Co-authored-by: ManInMyVan <[email protected]>
ManInMyVan
suggested changes
Oct 3, 2024
src/main/java/ac/grim/grimac/utils/collisions/datatypes/SimpleCollisionBox.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by Cotander, I've made a separate PR for all changes made that affect the simulation engine (Hitbox and CollisionBox changes, mostly)