🧪 Unit tests & dumper module #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
Impact on performances was too significant (more than a factor of 3)
View module changed because tests were failing in action. This was not due to bookshelf. This commit revert to the previous state while adding a support for dimensions.
20 tasks
|
Merging now! Missing tests will be followed in #146 and smaller PRs. The failing test action is due to a packtest bug (tests are run outside the worldborder). Hopefully this will get fix soon or we remove the worldborder restriction... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to bring Bookshelf to a stable state for a first release candidate!
Tasks
Unit tests
Bookshelf
Bookshelf Dev